[CRE-491] Move chainaccessor event ccip types to chainlink-common. #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
changed the title
pavel-raykov
changed the title
pavel-raykov
changed the title
|
This PR is stale because it has been open 30 days with no activity. |
pavel-raykov
force-pushed
the
move-accessor
branch
from
d8557cf to
153e7e9
Compare
pavel-raykov
had a problem deploying
to
integration
GitHub Actions
Error
pavel-raykov
had a problem deploying
to
integration
GitHub Actions
Error
pavel-raykov
had a problem deploying
to
integration
GitHub Actions
Error
pavel-raykov
force-pushed
the
move-accessor
branch
from
153e7e9 to
756eed4
Compare
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
force-pushed
the
move-accessor
branch
from
756eed4 to
555a1fc
Compare
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
changed the title
ogtownsend
reviewed
Jan 6, 2026
ogtownsend
previously approved these changes
Jan 6, 2026
pavel-raykov
force-pushed
the
move-accessor
branch
from
555a1fc to
5ea9354
Compare
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
pavel-raykov
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
approved these changes
Jan 6, 2026
pavel-raykov
requested review from
AmrMohamedRezk,
KodeyThomas,
asoliman92,
makramkd,
matYang,
tt-cll and
winder
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves CCIP chain accessor event types from the chainlink-ccip repository to chainlink-common, making them available as shared types. The changes include renaming PriceUpdates to AccessorPriceUpdates to avoid package name collision and inlining chainAddressNonce to its single usage location.
- Introduces new event types (
SendRequestedEvent,CommitReportAcceptedEvent,ExecutionStateChangedEvent) and their supporting structures - Renames
PriceUpdatestoAccessorPriceUpdatesto prevent naming conflicts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
|
|
||
| // --------------------------------------------------- | ||
| // The following types match the structs defined in the EVM contracts are used to decode these |
There was a problem hiding this comment.
Grammatical error in comment. Should read 'The following types match the structs defined in the EVM contracts and are used to decode these'.
Suggested change
| // The following types match the structs defined in the EVM contracts are used to decode these | |
| // The following types match the structs defined in the EVM contracts and are used to decode these |
| MessageHash Bytes32 | ||
| State uint8 | ||
| ReturnData Bytes | ||
| GasUsed big.Int |
There was a problem hiding this comment.
The GasUsed field should be a pointer *big.Int instead of big.Int to be consistent with other big.Int fields in this file (UsdPerToken and UsdPerUnitGas) and to avoid copying large values.
Suggested change
| GasUsed big.Int | |
| GasUsed *big.Int |
george-dorin
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports smartcontractkit/chainlink-ccip#1530
Also:
chainAddressNonceto the only place where it is usedPriceUpdates->AccessorPriceUpdatesdue to name collision in the packagegithub.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3