Fancy Graphics, Old Swing & Smooth Lighting checkboxes in options.

[MijaeLio]

amongaswag.mp4

swing.mp4

Description

Introduces checkboxes for Ambient Occlusion & Fancy Graphics, for enabling and disabling them.

Changes

• SettingsGraphicsMenu swf files.
• App_Defines.h
• App_enums.h
• UIScene_SettingsGraphicsMenu both .cpp and .h
• Consoles_app.cpp
• Extrax64Stubs
• GameRenderer
• TileRenderer
• MediaWindows64.arc

Previous Behavior

Ambient Occlusion and Fancy Graphics options were unused, left in the code but working.

Root Cause

There wasn't any option in-game to switch them.

New Behavior

You get new checkboxes for Graphics options for AO and FG.

Fix Implementation

Edited SWF files to add the checkboxes, Consoles_app.cpp so the settings save properly and for having effect on those options in-game, SettingsGraphicsMenu to add the new checkboxes in the code, defined GAMESETTING for the new options using uiBitmaskValues, restored function for AO in TileRenderer so it matches with the option.

AI Use Disclosure

No AI was used.

Related Issues

• Related to [Suggestion] Old Swinging Animation Toggle #864

[eh-K]

This is sick. Basically a toggle for TU1 style.

[codeHusky]

Ambient Occlusion should probably be renamed to “Smooth Lighting” to be more consistent with how it’s explained in Java edition, unless there’s some precedent for calling it that in LCE

[gizmogoat]

Since the other person mentioned how it makes it look more like TU1, maybe you could batch in a toggle for #864 here since it's also a very similar change? It was changed in #418 , hopefully it'd be simple to change it to be controllable with a checkbox: https://github.com/smartcmd/MinecraftConsoles/pull/418/changes

I was going to do it myself, but since I would have been doing this alongside you it would have conflicted with your changes and need manual merging, so I think it would be better for maintainers if done here.

[MijaeLio]

Since the other person mentioned how it makes it look more like TU1, maybe you could batch in a toggle for #864 here since it's also a very similar change? It was changed in #418 , hopefully it'd be simple to change it to be controllable with a checkbox: https://github.com/smartcmd/MinecraftConsoles/pull/418/changes

I was going to do it myself, but since I would have been doing this alongside you it would have conflicted with your changes and need manual merging, so I think it would be better for maintainers if done here.

Just added this in! On user interface options tho, but it is in

[MijaeLio]

Ambient Occlusion should probably be renamed to “Smooth Lighting” to be more consistent with how it’s explained in Java edition, unless there’s some precedent for calling it that in LCE

Changed the name too!

[neoapps-dev]

LGTM

[codeHusky]

Needs to default on with the existing rendering setup (Fancy graphics, render clouds, smooth lighting) as atm it's defaulting to the lowest graphics settings possible. Once that's fixed this should be fine to merge

[codeHusky]

Other issue, graphics settings are not persisting across relaunches