Merged
Conversation
Collaborator
|
Please test the world saving, run the version with new zlib and without and see if it does break anything. |
Contributor
Author
|
I'll test it. |
Contributor
Author
|
Looks fine to me, but only when I restart the game the New World thing appears. Was this always the case? |
Contributor
Author
|
Nevermind, those were just my old saves. |
Contributor
Author
Minecraft.Client_KokWgj28AD.mp4Saving looks good to me, sorry for the compression because I needed to fit the 10 MB file limit. |
tm5k
pushed a commit
to tm5k/RickCraft
that referenced
this pull request
Mar 7, 2026
tm5k
pushed a commit
to tm5k/RickCraft
that referenced
this pull request
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the game to zlib 1.3.2, because the previous version was full of vulnerabilities, including RCE. (Doesn't fix all RCE exploits, but fixes at least one cause).
One of the developers said that it's because of an old zlib version.
Changes
Previous Behavior
Previously, multiplayer would have been insecure by using the old version.
Root Cause
I guess because it's old and people don't code very good?
New Behavior
Multiplayer is more secure now, but there could still be RCE or other vulnerabilities from other sources.
Fix Implementation
I cloned the develop branch from the zlib GitHub repository and made a commit to it to my fork and opened this pull request.
AI Use Disclosure
No. This is the most simplest process, why use AI here?