Skip to content

Change F3 rendering and add git version information#836

Merged
codeHusky merged 11 commits intosmartcmd:mainfrom
rtm516:feature/f3-improvements
Mar 7, 2026
Merged

Change F3 rendering and add git version information#836
codeHusky merged 11 commits intosmartcmd:mainfrom
rtm516:feature/f3-improvements

Conversation

@rtm516
Copy link
Collaborator

@rtm516 rtm516 commented Mar 7, 2026

Description

Changes how we build the F3 screen and also embeds the git version information at build time.

This also moves the FPS, position and a few other lines to look more like java

image

Changes

Previous Behavior

F3 was created using a few different calls and lines were in hardcoded positions

New Behavior

F3 is much easier to add information to in future and re-arrange. Also added more lines to match java

Fix Implementation

We now add all the debug lines to a vector and then draw them all at the end

AI Use Disclosure

None was used

Related Issues

@lightyisreal
Copy link

Would it be possible to add word wrapping, so stuff that doesn't fit just goes into the next line?

@rtm516 rtm516 marked this pull request as draft March 7, 2026 14:43
@rtm516
Copy link
Collaborator Author

rtm516 commented Mar 7, 2026

Would it be possible to add word wrapping, so stuff that doesn't fit just goes into the next line?

We could but looking at how the structure list works it could loop forever and end up with alot of lines just for 1 feature type

@void2012
Copy link
Collaborator

void2012 commented Mar 7, 2026

@rtm516 consider removing Stronghold, Mineshaft, etc. lines because they are too cheaty.

@void2012
Copy link
Collaborator

void2012 commented Mar 7, 2026

Please don't touch the version yet, we still haven't decided with the versioning system for the current repo.

@rtm516
Copy link
Collaborator Author

rtm516 commented Mar 7, 2026

@rtm516 consider removing Stronghold, Mineshaft, etc. lines because they are too cheaty.

They are removed outside of debug builds, so in release they wont show up

@rtm516
Copy link
Collaborator Author

rtm516 commented Mar 7, 2026

Please don't touch the version yet, we still haven't decided with the versioning system for the current repo.

@void2012 I'm just replacing Xbox with LCE and the including the git info, happy to remove it but figured it was handy for now until we pick a proper version system

@codeHusky
Copy link
Collaborator

Considering it’s just the git hash I think this is reasonable enough, we can add to this or change it up once we switch off nightly and move to a real versioning system IMO. Though, it shouldn’t ever be “unknown” and if you’re building with uncommitted file changes it should be something like hash-DEV

@rtm516 rtm516 marked this pull request as ready for review March 7, 2026 18:13
@codeHusky
Copy link
Collaborator

codeHusky commented Mar 7, 2026

Compiling creates an unstaged difference with this code right now, adding -dev if you compile in VS without actually changing any files. This file should be restored after the compile's done

@codeHusky codeHusky force-pushed the feature/f3-improvements branch from 2e8363c to 2b207d8 Compare March 7, 2026 19:36
@codeHusky codeHusky merged commit 9cac3e0 into smartcmd:main Mar 7, 2026
1 check passed
@rtm516 rtm516 deleted the feature/f3-improvements branch March 7, 2026 21:33
tm5k pushed a commit to tm5k/RickCraft that referenced this pull request Mar 7, 2026
* Change F3 rendering and add git version information

* Change position, block, chunk and facing

* Limit position decimal places

* Move LCE unique to the bottom and add more java features

* Fix chunk information disappearing after y256

* Add chunk count information

* Move build number script to prebuild.ps1

* We dont need to specify vector and wstring are from std

* Restore build number to fix multiplayer

* Use short symbolic-ref

* Restore original BuildVer.h

---------

Co-authored-by: Loki <lokio.casebstv@gmail.com>
Co-authored-by: Loki Rautio <lokirautio@gmail.com>
tm5k pushed a commit to tm5k/RickCraft that referenced this pull request Mar 8, 2026
* Change F3 rendering and add git version information

* Change position, block, chunk and facing

* Limit position decimal places

* Move LCE unique to the bottom and add more java features

* Fix chunk information disappearing after y256

* Add chunk count information

* Move build number script to prebuild.ps1

* We dont need to specify vector and wstring are from std

* Restore build number to fix multiplayer

* Use short symbolic-ref

* Restore original BuildVer.h

---------

Co-authored-by: Loki <lokio.casebstv@gmail.com>
Co-authored-by: Loki Rautio <lokirautio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion] F3 Debug menu on Nightly Make F3 Debug menu look like on PC

4 participants