Bring new chat renderer up to parity with Iggy chat rendering#744
Open
KKNecmi wants to merge 20 commits intosmartcmd:mainfrom
Open
Bring new chat renderer up to parity with Iggy chat rendering#744KKNecmi wants to merge 20 commits intosmartcmd:mainfrom
KKNecmi wants to merge 20 commits intosmartcmd:mainfrom
Conversation
codeHusky
changed the title
… formatting to chat history
Contributor
Author
|
missing type box scale format |
…d yadjust for positioing the typechatbar
…ables in set uiscale
…finded best offsets and y adjustments
Collaborator
|
is this actually ready now? |
Contributor
Author
|
yes |
Contributor
Author
|
but i think i could make it good look more? theres some bad things about it for to be %100 sure its good to i might send couple commits more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds the better chat again with legacy's color style & fixes chat gui scale
Changes
background color changed black to gray opacity lowered min height of the chat hightened
Previous Behavior
too big text size,text overlay going over health & armor bars,worse background color and opacity,gui scale gived chat offset
Root Cause
not best desing style better chat owner bringed system for making chat easier and functional more than legacys style,not looking gui style while scaling
New Behavior
new background,text color & new background opacity & chat text resize & chat minimum height hightened,gui calculates gui style while scaling
Fix Implementation
edited design colors/sizes/positions inside Gui.cpp , ChatScreen.cpp render takes scale factor of gui scale
AI Use Disclosure
Ai was used to get good ui colors (ex. 0x404040)
Related Issues