Skip to content

Disable zizmor GitHub Advanced Security upload by default #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tashian merged 2 commits into from
Mar 3, 2026
Merged

Disable zizmor GitHub Advanced Security upload by default #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dc928
ci: Disable zizmor GitHub Advanced Security upload by default
tashian Mar 3, 2026
ff654e2
ci: Remove zizmor/frizbee from goCI, fix actionci default, rename jobs
tashian Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/actionci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
description: Upload zizmor results to GitHub Advanced Security
required: false
type: boolean
default: true
default: false

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/frizbee.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:

jobs:
frizbee:
name: Check action pinning
name: frizbee
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/goCI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,6 @@ jobs:
PAT: ${{ secrets.PAT }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

zizmor:
uses: ./.github/workflows/zizmor.yml

frizbee:
uses: ./.github/workflows/frizbee.yml

build:
Copy link
Contributor Author

@tashian tashian Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dopey these were running twice in some cases because they are in goCI and in actionci. Do we want them in both places?

uses: ./.github/workflows/goBuild.yml
if: inputs.run-build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ on:
advanced-security:
description: Upload results to GitHub Advanced Security
type: boolean
default: true
default: false

jobs:
zizmor:
name: Scan GitHub workflows
name: zizmor
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
Loading