-
Notifications
You must be signed in to change notification settings - Fork 12
slog 2.8 deprecation warnings fix #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| use std::result; | ||
|
|
||
| pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn}; | ||
| pub use slog::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mark these names as deprecated too now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the least-effort path 😅 But it crossed my mind for a second, too. The decision is up to you 😉
By running 'cargo update slog --precise 2.7.0'. This is due to a mishandled deprecation in 'slog-scope' crate. This PR once merged should fix the problem: slog-rs/scope#15
By running 'cargo update slog --precise 2.7.0'. This is due to a mishandled deprecation in 'slog-scope' crate. This PR once merged should fix the problem: slog-rs/scope#15
By running 'cargo update slog --precise 2.7.0'. This is due to a mishandled deprecation in 'slog-scope' crate. This PR once merged should fix the problem: slog-rs/scope#15
|
@dpc Bump pls :) |
|
chiming in also to see if this could be merged. I am seeing similar deprecation warnings recently and this PR would fix them. |
|
@dpc @Techcable 🙏🏻 Why not just merge this? |
It looks good to me. Unfortunately, I don't have merge permission on this repo, so @dpc will need to merge it. |
Hello, offering the upstream a tiny fix to get around some fresh deprecation warnings: