Skip to content

Conversation

@jendakol
Copy link

@jendakol jendakol commented Oct 6, 2025

Hello, offering the upstream a tiny fix to get around some fresh deprecation warnings:

warning: use of deprecated macro `slog::slog_crit`: Use fully qualified macro slog::crit!(...) instead
  --> lib.rs:70:16
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                ^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: use of deprecated macro `slog::slog_debug`: Use fully qualified macro slog::warn!(...) instead
  --> lib.rs:70:27
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                           ^^^^^^^^^^

warning: use of deprecated macro `slog::slog_error`: Use fully qualified macro slog::crit!(...) instead
  --> lib.rs:70:39
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                                       ^^^^^^^^^^

warning: use of deprecated macro `slog::slog_info`: Use fully qualified macro slog::info!(...) instead
  --> lib.rs:70:51
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                                                   ^^^^^^^^^

warning: use of deprecated macro `slog::slog_trace`: Use fully qualified macro slog::trace!(...) instead
  --> lib.rs:70:62
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                                                              ^^^^^^^^^^

warning: use of deprecated macro `slog::slog_warn`: Use fully qualified macro slog::warn!(...) instead
  --> lib.rs:70:74
   |
70 | pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
   |                                                                          ^^^^^^^^^

  • one even tinier clippy warning fix :)

use std::result;

pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
pub use slog::{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mark these names as deprecated too now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the least-effort path 😅 But it crossed my mind for a second, too. The decision is up to you 😉

@jendakol jendakol requested a review from dpc October 9, 2025 07:38
jpraynaud added a commit to input-output-hk/mithril that referenced this pull request Oct 16, 2025
By running 'cargo update slog --precise 2.7.0'.
This is due to a mishandled deprecation in 'slog-scope' crate.
This PR once merged should fix the problem: slog-rs/scope#15
jpraynaud added a commit to input-output-hk/mithril that referenced this pull request Oct 16, 2025
By running 'cargo update slog --precise 2.7.0'.
This is due to a mishandled deprecation in 'slog-scope' crate.
This PR once merged should fix the problem: slog-rs/scope#15
jpraynaud added a commit to input-output-hk/mithril that referenced this pull request Oct 16, 2025
By running 'cargo update slog --precise 2.7.0'.
This is due to a mishandled deprecation in 'slog-scope' crate.
This PR once merged should fix the problem: slog-rs/scope#15
@jendakol
Copy link
Author

@dpc Bump pls :)

@dpc dpc requested a review from Techcable October 23, 2025 17:19
@chantra
Copy link

chantra commented Dec 10, 2025

chiming in also to see if this could be merged. I am seeing similar deprecation warnings recently and this PR would fix them.

@jendakol
Copy link
Author

@dpc @Techcable 🙏🏻 Why not just merge this?

@Techcable
Copy link
Member

Techcable commented Dec 12, 2025

@dpc @Techcable 🙏🏻 Why not just merge this?

It looks good to me.

Unfortunately, I don't have merge permission on this repo, so @dpc will need to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants