add bpms#36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds and improves support for verifying and mapping Beam Position Monitor (BPM) process variables (PVs) in the BMAD virtual accelerator models. The main changes include enhancements to BPM element detection and mapping logic, as well as new tests to ensure BPM PVs are correctly exposed and mapped in the model.
BPM Support and Mapping Improvements:
get_variablesinvirtual_accelerator/bmad/variables.pyto explicitly handle BPMs by name, ensuring they are treated as BPMs even if their device type is generic (Monitor).get_tao_propertyinvirtual_accelerator/bmad/cu_transformer.pyto support returning BPM X and Y orbit positions (converted from meters to millimeters).Testing Enhancements:
assert_bpm_pvs_match_tao_latticeutility invirtual_accelerator/tests/_bmad_model_test_utils.pyto verify that all BPM lattice elements have corresponding PV mappings and that expected BPM PVs are present in the model's supported variables.test_cu_hxr.pyandtest_facet.py), adding dedicated tests to check BPM PV mappings. [1] [2] [3] [4]