feat: add mcp_servers field to app manifest#580
Draft
zimeg wants to merge 1 commit into
Draft
Conversation
Support MCP server configuration in the app manifest with url, auth_provider_key, and auth_type fields for Slack MCP Client integration. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
+ Coverage 71.66% 71.69% +0.03%
==========================================
Files 226 226
Lines 19148 19148
==========================================
+ Hits 13723 13729 +6
+ Misses 4216 4214 -2
+ Partials 1209 1205 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Add
mcp_serversmanifest field to support Slack MCP Client integration, allowing apps to declare MCP server connections with configurable authentication.Summary
This pull request adds the
mcp_serversfield to the app manifest struct, enabling apps to configure MCP (Model Context Protocol) server connections.The new
MCPServerstruct supports:url(required) — HTTPS endpoint of the MCP serverauth_provider_key(optional) — reference to anexternal_auth_providersentry for OAuthauth_type(optional) — authentication method (no_auth,slack_identity_auth,manual_auth,dynamic_client_registration)Schema definition: slackapi/manifest-schema#71
Preview
N/A — no UI changes.
Testing
mcp_serversis properly serialized/deserialized in JSON manifests with various auth configurationsgo test ./internal/shared/types/Notes
external_auth_providersfield already exists;mcp_serversreferences it viaauth_provider_keyuse_pkceandtoken_url_configfields added in the schema PR are already supported here since oauth2 provider options use*RawJSON(passthrough)semver:patch— new field is additive and behind a feature flag on the platform sideRequirements