ci: skip release candidate if generated reference match current release#575
Open
zimeg wants to merge 1 commit into
Open
ci: skip release candidate if generated reference match current release#575zimeg wants to merge 1 commit into
zimeg wants to merge 1 commit into
Conversation
zimeg
force-pushed
the
fix/rc-no-changes-commit
branch
from
5d55f92 to
d8aa5c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 71.66% 71.69% +0.03%
==========================================
Files 226 226
Lines 19148 19148
==========================================
+ Hits 13723 13729 +6
+ Misses 4218 4214 -4
+ Partials 1207 1205 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The release workflow re-triggers on main when its own PR merges, causing `make rc` to fail with "nothing to commit" since docs are already up to date. Check if the computed NEXT_VERSION already appears in the install docs before proceeding. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
force-pushed
the
fix/rc-no-changes-commit
branch
from
d8aa5c4 to
ad3d90b
Compare
zimeg
commented
Jun 4, 2026
Member
Author
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
🔮 A comment of the current approach - I don't think this is rushed to merge until next release and it shouldn't be blocking a release either!
Comment on lines
+87
to
+92
| # Skip if docs already reference this version | ||
| if grep -q "Using slack v${NEXT_VERSION}" docs/guides/installing-the-slack-cli-for-mac-and-linux.md; then | ||
| echo "Docs already at v$NEXT_VERSION, nothing to release" | ||
| echo "has_changes=false" >> "$GITHUB_OUTPUT" | ||
| exit 0 | ||
| fi |
Member
Author
There was a problem hiding this comment.
🪬 thought: Curious of perhaps recommended place to search for the latest version after discussion with @lukegalbraithrussell and @srtaalej earlier! This current approach isn't certain IMHO.
👾 ramble: Overall I prefer checking for an expected version here to skip the "commit" and "PR" steps following if no changes are found without adding to those steps!
zimeg
added
semver:patch
zimeg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This PR fixes the release workflow attempting to create an RC PR if generated changes match what's current on
mainbranch. This happens during the release process between merge and tag or if no semver labels exist on PRs since a latest tag.Preview
Error: https://github.com/slackapi/slack-cli/actions/runs/26916634889/job/79407765870
Note: We might not test this until next RC candidate merges unless we avoid adding a label before merge perhaps? I do not know!
Notes
make rccommand still errors if a commit isn't created (no changes needed for docs) to show the RC failed and matches stables instead. I comment that our check for this is interesting...Requirements