Conversation
🦋 Changeset detectedLatest commit: 538e326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
- Coverage 90.67% 87.40% -3.28%
==========================================
Files 82 62 -20
Lines 14994 10235 -4759
Branches 508 409 -99
==========================================
- Hits 13596 8946 -4650
+ Misses 1373 1267 -106
+ Partials 25 22 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice 💯 thanks for working on this 🚀
I noticed the code coverage went down 🤔 after some investigation with codecov I think this is due to some packages previously including tests in their tracking, this PR fixes this, the new code coverage should be the more accurate one
Example packages/oauth/src/installation-stores:
|
NOTE: we should try to get our coverage back up 90% 🤔 |
# Conflicts: # packages/cli-hooks/package.json # packages/cli-test/package.json # packages/logger/package.json # packages/socket-mode/package.json # packages/webhook/package.json
|
@WilliamBergamin That's an odd find... But I agree that we should continue to increase coverage with changes. Let's merge this for now to keep tests confident across versions 🧪 ✨ |
Summary
This PR adds support for
node24 version - the current active LTS release - to our testing matrix for #2359 👾 ✨📚 https://nodejs.org/en/about/previous-releases
Requirements