Skip to content

ci: add support for node 24 version#2534

Merged
zimeg merged 7 commits intomainfrom
node24
Mar 12, 2026
Merged

ci: add support for node 24 version#2534
zimeg merged 7 commits intomainfrom
node24

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 3, 2026

Summary

This PR adds support for node 24 version - the current active LTS release - to our testing matrix for #2359 👾 ✨

📚 https://nodejs.org/en/about/previous-releases

Requirements

@zimeg zimeg self-assigned this Mar 3, 2026
@zimeg zimeg requested a review from a team as a code owner March 3, 2026 23:39
@zimeg zimeg added docs M-T: Documentation work only semver:patch enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` dependencies Pull requests that update a dependency file labels Mar 3, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: 538e326

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@slack/socket-mode Patch
@slack/cli-hooks Patch
@slack/cli-test Patch
@slack/web-api Patch
@slack/webhook Patch
@slack/logger Patch
@slack/oauth Patch
@slack/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.40%. Comparing base (9b23414) to head (538e326).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
- Coverage   90.67%   87.40%   -3.28%     
==========================================
  Files          82       62      -20     
  Lines       14994    10235    -4759     
  Branches      508      409      -99     
==========================================
- Hits        13596     8946    -4650     
+ Misses       1373     1267     -106     
+ Partials       25       22       -3     
Flag Coverage Δ
cli-hooks 87.40% <ø> (-3.28%) ⬇️
cli-test 87.40% <ø> (-3.28%) ⬇️
logger 87.40% <ø> (-3.28%) ⬇️
oauth 87.40% <ø> (-3.28%) ⬇️
socket-mode 87.40% <ø> (-3.28%) ⬇️
web-api 87.40% <ø> (-3.28%) ⬇️
webhook 87.40% <ø> (-3.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 thanks for working on this 🚀

I noticed the code coverage went down 🤔 after some investigation with codecov I think this is due to some packages previously including tests in their tracking, this PR fixes this, the new code coverage should be the more accurate one

Example packages/oauth/src/installation-stores:

@WilliamBergamin
Copy link
Contributor

NOTE: we should try to get our coverage back up 90% 🤔

Base automatically changed from types18 to main March 12, 2026 22:34
zimeg added 2 commits March 12, 2026 16:39
# Conflicts:
#	packages/cli-hooks/package.json
#	packages/cli-test/package.json
#	packages/logger/package.json
#	packages/socket-mode/package.json
#	packages/webhook/package.json
@zimeg
Copy link
Member Author

zimeg commented Mar 12, 2026

@WilliamBergamin That's an odd find... But I agree that we should continue to increase coverage with changes. Let's merge this for now to keep tests confident across versions 🧪 ✨

@zimeg zimeg merged commit b8d922f into main Mar 12, 2026
12 of 13 checks passed
@zimeg zimeg deleted the node24 branch March 12, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docs M-T: Documentation work only enhancement M-T: A feature request for new functionality pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants