Conversation
3e14d23 to
00d5ae9
Compare
e89d8df to
de4c3df
Compare
de4c3df to
413f9ea
Compare
413f9ea to
f02df53
Compare
zimeg
left a comment
There was a problem hiding this comment.
🏁 Leaving a few milestones for triage before we merge this!
- cli-hooks@next: https://github.com/slackapi/node-slack-sdk/milestone/163
- cli-test@next: https://github.com/slackapi/node-slack-sdk/milestone/162
- oauth@next: https://github.com/slackapi/node-slack-sdk/milestone/151
- socket-mode@next: https://github.com/slackapi/node-slack-sdk/milestone/152
- types@next: https://github.com/slackapi/node-slack-sdk/milestone/165
- web-api@next: https://github.com/slackapi/node-slack-sdk/milestone/164
- webhook@next: https://github.com/slackapi/node-slack-sdk/milestone/68
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 62 62
Lines 10235 10235
Branches 409 409
=======================================
Hits 8946 8946
Misses 1267 1267
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
@changesets LGTM! Quite a few changes included for docs but this is something we can read into later 📚
| ```ts | ||
| generateInstallUrl( | ||
| options, | ||
| stateVerification, |
There was a problem hiding this comment.
📝 note: This is an improvement to the docs dependencies it seems! This now reflects actual optional but default parameters:
| 2. **Review the release PR**: Verify that version bumps match expectations, `CHANGELOG` entries are clear, and CI checks pass on the `main` branch. | ||
| 2. **Review the release PR**: Verify that version bumps match expectations, `CHANGELOG` entries are clear, and CI checks pass on the `main` branch. Use `npm run docs` to generate documentation. | ||
|
|
There was a problem hiding this comment.
🔭 note: We might have removed this step in prior changes and missed updates in recent releases. I'm adding this as a manual step for now but hope we can automate it - either per PR or within this release branch.
👾 ramble: I forget how changes are published, but if it's according to the main branch of this project we might prefer generating changes in the release PR?
| static stackTraceLimit: number; | ||
| ``` | ||
|
|
||
| Defined in: packages/oauth/node\_modules/@types/node/globals.d.ts:162 |
There was a problem hiding this comment.
🔍 note: The changes of #2532 share the @types/node package used for maintainers when generating documentation. I think this path is less confusing since it's common to have in development.
|
|
||
| # Interface: FileSharedEvent | ||
|
|
||
| Defined in: packages/web-api/node\_modules/@slack/types/dist/events/file.d.ts:40 |
There was a problem hiding this comment.
👾 note: This might've been discussed earlier but the workspaces setup makes this path reference adjacent packages more direct! I'm curious if we can use source maps to avoid referencing the dist path but for now this continues to match the released versions.
| optional factor: number; | ||
| ``` | ||
|
|
||
| Defined in: packages/web-api/node\_modules/@types/retry/index.d.ts:125 |
There was a problem hiding this comment.
👾 note: We surface these definitions of dependencies more direct which might be confusing with the node_modules path for an unspecified package. This change might still be alright since it should match the developer's path for a required package:
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@slack/web-api@7.15.0
Minor Changes
Patch Changes
@slack/cli-hooks@1.3.1
Patch Changes
@slack/cli-test@2.2.2
Patch Changes
@slack/logger@4.0.1
Patch Changes
@slack/oauth@3.0.5
Patch Changes
@slack/socket-mode@2.0.6
Patch Changes
@slack/types@2.20.1
Patch Changes
@slack/webhook@7.0.8
Patch Changes