SK-2296 Use sessions for insert method #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimise connection pooling by usine sessions - Add retry for connection and 500 errors
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
skyflow-shravan
approved these changes
Sep 16, 2025
skyflow-shravan
added a commit
that referenced
this pull request
Sep 18, 2025
* Merge pull request #199 from skyflowapi/skyflow-vivek/SK-2296-use-sessions-for-insert SK-2296 Use sessions for insert method * [AUTOMATED] Private Release 1.15.4.dev0+1c45049 --------- Co-authored-by: skyflow-vivek <121149418+skyflow-vivek@users.noreply.github.com> Co-authored-by: skyflow-shravan <skyflow-shravan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
insertmethod to utilisesessionsprovided byrequestslibrary.Why
requests.postleads to choking and connection errors.sessionsinstead.Goal
sessionsTesting