Skip to content

Conversation

@skyflow-vivek
Copy link
Collaborator

This PR adds typescript interfaces across JS SDK codebase

Why

  • The SDK code had typescript related gaps where types were not properly defined for method parameters, return types, variables, etc.

Goal

  • We identified and fixed those gaps by introducing proper types for better typescript support and type safety.

Testing

  • Tested the changes manually.
  • Fixed some failing existing unit tests.
  • Added unit tests in typescript with type safety.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

- Add additional unit tests and fixed sample
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

1 similar comment
@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

🔐 Gitleaks Findings: 2 issue(s) detected

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-container.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-container.test.ts:null

🔸 Rule: generic-api-key
📄 File: tests/core/external/reveal/reveal-element.test.ts:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: tests/core/external/reveal/reveal-element.test.ts:null

@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

1 similar comment
@github-actions
Copy link

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants