SK-2418 Add vaultURL as config parameter in VaultConfig #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor `VaultConfig` POJO to `V2` and `V3` modules along with unit tests. - Made necessary changes to `common` module including cleaning imports. - Added vaultURL config parameter only for `V3` module's `VaultConfig`. - Added unit tests and logic for proper prioritisation of `vaultURL`. - `vaultURL` (config) > `vaultURL` (env) > `clusterId` (config). - Added validations to ensure atlease one of `vaultURL` or `clusterId` is provided.
- New priority order is: vaultURL (env) > vaultURL (config) > clusterId (config)
Devesh-Skyflow
approved these changes
Nov 27, 2025
common/src/main/java/com/skyflow/utils/validations/BaseValidations.java
Outdated
Show resolved
Hide resolved
skyflow-bharti
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding custom vault URL directly through config parameters in V3 SDK.
VaultConfigPOJO toV2andV3modules along with unit tests.commonmodule including cleaning imports.V3module'sVaultConfig.vaultURL.vaultURLorclusterIdis provided.Why
Goal
vaultURLboth asENVvariable and/or as config parameter.vaultURL(env) >vaultURL(config) >clusterId(config).Testing