Skip to content

SK-2343: Maintain the Java v2 SDK's code and documentation in the main branch #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saileshwar-skyflow merged 161 commits into from
Oct 14, 2025
Merged

SK-2343: Maintain the Java v2 SDK's code and documentation in the main branch #253

saileshwar-skyflow merged 161 commits into from
Oct 14, 2025

Conversation

@saileshwar-skyflow
Copy link
Collaborator

@saileshwar-skyflow saileshwar-skyflow commented Oct 10, 2025

Why

  • The main branch currently contains outdated v1 SDK code and README.
  • The latest v2 SDK (GA) exists in a separate v2 branch, which can confuse users.
  • Users generally expect the main branch to always reflect the latest version.

Outcome

  • Move v2 SDK code, samples, and README to the main branch.
  • Create and retain a separate v1 branch for any future patches or reference.
  • Ensure the main branch clearly represents the latest stable version (v2).

skyflow-vivek and others added 30 commits September 17, 2024 10:51
@skyflow-vivek
SK-1663 Basic scaffolding and project structure for v2
caa3b1c
@skyflow-vivek
SK-1663 Worked on feedback for scaffolding
f44be85
@skyflow-vivek
SK-1663 Moved main dir to src dir
f9df247
@skyflow-vivek
SK-1663 Scaffolding for java sdk v2
35762d2 
- Renamed packages according to design doc for sdk v2
@skyflow-vivek
SK-1663 Java sdk v2 scaffolding worked on feedback
45d96f9
@skyflow-vivek
SK-1663 Update method signatures for all controllers
ad543ad
@skyflow-vivek
SK-1663 Worked on feedback for java sdk v2 scafolding
f44c1f7 
- SK-1677 Worked on client intialisation for Java SDK v2
@skyflow-vivek
SK-1677 Delete old vault controller implementation
9eba2dd
@skyflow-vivek
SK-1677 Client Initilisation and Credentials priorotisation
f7ee304
@skyflow-vivek
SK-1677 Client initilisation and credentials prioritisation
786055d
@skyflow-vivek
SK-1677 Used Constants instead of hard-coded strings
6049e1c
@skyflow-vivek
SK-1678 Bearer Token uitlities
988ab14 
- Implemented bearer token utilities for generating bearer token with or without context and roles
- Implemented Token utilties to check for validity of tokens
- Implemented signed data tokens utilities to generate signed data tokens
@skyflow-vivek
SK-1665 Generate and integrate Data API code
5ad62c7
@skyflow-vivek
SK-1664 Public interfaces for vault APIs
54cf369 
- SK-1703 Implemented public interfaces for detokenize
@skyflow-vivek
SK-1701 Implemented public interfaces for insert vault API
c511774
@skyflow-vivek
SK-1703 Worked on feedback for Detokenize public interfaces
96ab82c
@skyflow-vivek
SK-1701 Worked on feedback for Insert public interfaces
864159e
@skyflow-vivek
SK-1702 Implement public interfaces for Get vault API
4aabe84
@skyflow-vivek
SK-1678 Replaced use of JSONObject with Gson JsonObject
3246b37 
SK-1703 Abstracted constructor for Detokenize Request Builder
@skyflow-vivek
SK-1664 Implement vault API public interfaces
382877b 
- SK-1701 Modified insert public interfaces
- SK-1702 Modified get public interfaces
- SK-1704 Implemented update public interfaces
@skyflow-vivek
SK-1707 Implement Delete API public interfaces
0ad69e4
@skyflow-vivek
SK-1705 Implement Query API public interfaces
df0a13f
@skyflow-shravan
SK-1664 implement tokenize api public interface
de7eddc
@skyflow-shravan
SK-1666 implement invoke connection public interface
d441a28
@skyflow-vivek
SK-1701 Add continueOnError in insert vault API public interface
5496e94
@skyflow-vivek
SK-1681 Add validations
19aa8ce
@skyflow-shravan
SK-1681 add validations for tokenize request
9e04420
@skyflow-shravan
SK-1666 validations for invoke connection request
c4ad6c5
@skyflow-shravan
SK-1664 move ColumnValue class to tokens package
b56f6ef
@skyflow-vivek
SK-1664 Implement vault API interfaces
b08a535 
- Change builder pattern implementation for vault API interfaces
skyflow-vivek and others added 3 commits August 1, 2025 20:09
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

🔐 Gitleaks Findings: 9 issue(s) detected

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/ConnectionClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/ConnectionClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: private-key
📄 File: v2/src/test/resources/invalidTokenURICredentials.json:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/test/resources/invalidTokenURICredentials.json:null

🔸 Rule: generic-api-key
📄 File: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null

🔸 Rule: private-key
📄 File: v2/src/main/java/com/skyflow/utils/Constants.java:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Constants.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v1/src/main/java/DetokenizeExample.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v1/src/main/java/DetokenizeExample.java:null

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@saileshwar-skyflow
SK-2342: Update README and samples for V2 (#254)
a490c80 
* SK-2342: update readme and samples
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🔐 Gitleaks Findings: 9 issue(s) detected

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/ConnectionClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/ConnectionClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: private-key
📄 File: v2/src/test/resources/invalidTokenURICredentials.json:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/test/resources/invalidTokenURICredentials.json:null

🔸 Rule: generic-api-key
📄 File: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null

🔸 Rule: private-key
📄 File: v2/src/main/java/com/skyflow/utils/Constants.java:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Constants.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v1/src/main/java/DetokenizeExample.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v1/src/main/java/DetokenizeExample.java:null

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🔐 Gitleaks Findings: 9 issue(s) detected

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/ConnectionClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/ConnectionClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: private-key
📄 File: v2/src/test/resources/invalidTokenURICredentials.json:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/test/resources/invalidTokenURICredentials.json:null

🔸 Rule: generic-api-key
📄 File: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null

🔸 Rule: private-key
📄 File: v2/src/main/java/com/skyflow/utils/Constants.java:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Constants.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v1/src/main/java/DetokenizeExample.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v1/src/main/java/DetokenizeExample.java:null

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🔐 Gitleaks Findings: 9 issue(s) detected

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/ConnectionClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/ConnectionClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: private-key
📄 File: v2/src/test/resources/invalidTokenURICredentials.json:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/test/resources/invalidTokenURICredentials.json:null

🔸 Rule: generic-api-key
📄 File: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null

🔸 Rule: private-key
📄 File: v2/src/main/java/com/skyflow/utils/Constants.java:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Constants.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v1/src/main/java/DetokenizeExample.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v1/src/main/java/DetokenizeExample.java:null

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

skyflow-vivek
skyflow-vivek reviewed Oct 13, 2025
View reviewed changes
skyflow-vivek
skyflow-vivek reviewed Oct 13, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🔐 Gitleaks Findings: 9 issue(s) detected

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/ConnectionClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/ConnectionClientTests.java:null

🔸 Rule: generic-api-key
📄 File: src/test/java/com/skyflow/VaultClientTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: src/test/java/com/skyflow/VaultClientTests.java:null

🔸 Rule: private-key
📄 File: v2/src/test/resources/invalidTokenURICredentials.json:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/test/resources/invalidTokenURICredentials.json:null

🔸 Rule: generic-api-key
📄 File: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null
📝 Description: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
🔑 Secret: **********
🔗 Path: v2/src/test/java/com/skyflow/vault/config/CredentialsTests.java:null

🔸 Rule: private-key
📄 File: v2/src/main/java/com/skyflow/utils/Constants.java:null
📝 Description: Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Constants.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v2/src/main/java/com/skyflow/utils/Utils.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v2/src/main/java/com/skyflow/utils/Utils.java:null

🔸 Rule: jwt
📄 File: v1/src/main/java/DetokenizeExample.java:null
📝 Description: Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
🔑 Secret: **********
🔗 Path: v1/src/main/java/DetokenizeExample.java:null

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@saileshwar-skyflow saileshwar-skyflow merged commit 167cd47 into main Oct 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyflow-vivek skyflow-vivek skyflow-vivek approved these changes

+1 more reviewer

@skyflow-shravan skyflow-shravan skyflow-shravan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saileshwar-skyflow @skyflow-vivek @skyflow-shravan