Skip to content

SK-2315 add version as prefix to logs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyflow-shravan merged 1 commit into from
Oct 3, 2025
Merged

SK-2315 add version as prefix to logs #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions v3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<maven.compiler.target>8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.deploy.skip>false</maven.deploy.skip>
<sdk.version>${project.version}</sdk.version>
</properties>


Expand All @@ -48,6 +49,12 @@
</dependencies>

<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
</resource>
</resources>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down
27 changes: 25 additions & 2 deletions v3/src/main/java/com/skyflow/utils/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
package com.skyflow.utils;

import java.io.IOException;
import java.io.InputStream;
import java.util.Properties;

public final class Constants extends BaseConstants {
public static final String SDK_NAME = "Skyflow Java SDK ";
public static final String SDK_VERSION = "3.0.0-beta.6";
public static final String SDK_VERSION;
public static final String VAULT_DOMAIN = ".skyvault.";
public static final String SDK_PREFIX = SDK_NAME + SDK_VERSION;
public static final String SDK_PREFIX;
public static final Integer INSERT_BATCH_SIZE = 50;
public static final Integer MAX_INSERT_BATCH_SIZE = 1000;
public static final Integer INSERT_CONCURRENCY_LIMIT = 1;
Expand All @@ -13,5 +17,24 @@ public final class Constants extends BaseConstants {
public static final Integer DETOKENIZE_CONCURRENCY_LIMIT = 1;
public static final Integer MAX_DETOKENIZE_BATCH_SIZE = 1000;
public static final Integer MAX_DETOKENIZE_CONCURRENCY_LIMIT = 10;
public static final String DEFAULT_SDK_VERSION = "v3";

static {
String sdkVersion;
// Use a static initializer block to read the properties file
Properties properties = new Properties();
try (InputStream input = Constants.class.getClassLoader().getResourceAsStream("sdk.properties")) {
if (input == null) {
sdkVersion = DEFAULT_SDK_VERSION;
} else {
properties.load(input);
sdkVersion = properties.getProperty("sdk.version", DEFAULT_SDK_VERSION);
}
} catch (IOException ex) {
sdkVersion = DEFAULT_SDK_VERSION;
}
SDK_VERSION = sdkVersion;
SDK_PREFIX = SDK_NAME + " " + SDK_VERSION;
}

}
1 change: 1 addition & 0 deletions v3/src/main/resources/sdk.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
sdk.version=${sdk.version}
Loading