SK-1684 Add Unit Tests #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests for Detokenize request validations - Added unit tests for Insert request validations - Added unit tests for Get request validations - Added unit tests for Update request validations - Added unit tests for Delete request validations - Added unit tests for Query request validations
- SK-1681 Updated validation checks for Get request interface
- Add unit tests for configs i.e. vault, connection and credentials - Add unit tests for response pojo classes for few vault API interfaces
SK-1684 Add unit tests for Tokenize request validations
…onnection-public-interface
…ection-public-interface SK-1666 implement invoke connection public interface
SK-1766 Add validations for invoke connection interface SK-1766 Refactor code for invoke connection, removed unnecessary components for code optimisation
Removed v1,v2 modules and moved all v2 code directly to parent module Removed unnecessary dependencies
skyflow-vivek
force-pushed
the
SK-1684-add-unit-tests
branch
from
3efaa27 to
6027972
Compare
skyflow-vivek
force-pushed
the
SK-1684-add-unit-tests
branch
2 times, most recently
from
ab96f90 to
3848d80
Compare
- Excluding generating code from javadoc generation
skyflow-vivek
force-pushed
the
SK-1684-add-unit-tests
branch
from
3848d80 to
f63b903
Compare
amith-skyflow
approved these changes
Nov 19, 2024
skyflow-vivek
merged commit 1b57ba7
into
SK-1663-java-sdk-v2-scaffolding
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the Skyflow SDKs in terms of Developer Experience (DevEx), performance, efficiency, security, error handling, logging, compatibility, and versioning, we have developed a new design for the V2 implementation of the SDKs. This design needs to be implemented according to best practices, language-specific nuances, and design patterns to ensure that the SDKs are extendable, more efficient, and developer-friendly.