Fix statefulset cross-namespace

[iagodvsantos]

What is it?

While testing 1.4.0-rc1 release I stumbled upon an issue while exposing a statefulset cross-namespace due to the tcp/http connector host address to be referring to the current namespace instead of the one specified by the --target-namespace flag.

[iagodvsantos]

@fgiorgetti @grs @nluaces
Could you guys take a look?

For some reason, the test coverage step is exceeding the time limit on Circleci, it's running normally locally though

[iagodvsantos]

Hey guys! Just following up on this PR @fgiorgetti @grs @nluaces. Have you had the chance to take a look at it?

[nluaces]

Hi @iagodvsantos thanks for your patience, there was a change in the circle-ci configuration (unrelated to your PR) but in order to run the build again, we need that you rebase the changes from master branch into your branch; to catch up those changes.

[iagodvsantos]

Thanks for replying back @nluaces !
Just rebased

[nluaces]

@iagodvsantos I have seen that you have added some unit tests, and also that your changes would affect only to statefulsets exposed with --headless (if I am not mistaken). How have you tested this particular use case? could you describe the manual test that you have done for this pull request? Thanks!

[iagodvsantos]

@nluaces I've stumbled upon this issue while exposing a Kafka statefulset deployed in a different namespace. I noticed that the consumer app couldn't even resolve the kafka hosts to fetch initial metadata to start consuming.
When I realized that the host returned by the proxy was including the namespace of the skupper site (instead of the namespace where the statefulset was actually deployed to).
After this, I generated a new docker image for the sake of this test, and now it's working properly.
In my last PR to expose deployments/statefulset cross-namespace I missed this particular point.

[nluaces]

Looks good to me, thanks!

[fgiorgetti]

LGTM

[nluaces]

Hi @iagodvsantos could you rebase from the last changes from main? There are a few improvements related to CI. Thanks!

[shinji62]

@nluaces @iagodvsantos
Just got hit by this issue, I was expected the service to be in the namespace where the pod are deployed, instead they refer to the namespace where the site(linked) is...

for example
ns-a and ns-b are link
poda are deployed in ns-a
I am expecting to resollve poda.ns-a..... from ns-b podb, but instead I can only resolve poda.ns-b.

[iagodvsantos]

I'll rebase the PR. Thanks