[BUG] Correct probability mass and temporal alignment in _SksurvAdapter #958#970
Open
vishalsnghkush wants to merge 1 commit intosktime:mainfrom
Open
[BUG] Correct probability mass and temporal alignment in _SksurvAdapter #958#970vishalsnghkush wants to merge 1 commit intosktime:mainfrom
vishalsnghkush wants to merge 1 commit intosktime:mainfrom
Conversation
…ter - Added boundary handling by prepending S(0)=1.0 to survival curves. - Appended remaining survival probability (tail mass) to np.inf. - Corrected temporal alignment of mass drops to match event times. - Resolves Issue sktime#958: weights now sum to 1.0.
vishalsnghkush
requested review from
felipeangelimvieira and
fkiraly
as code owners
fkiraly
added
bug
module:survival&time-to-event
fkiraly
requested changes
Mar 26, 2026
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Can you comment why you did not use the _surf_diff function?
fkiraly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #958
This PR fixes mathematical errors in the predict_proba method of _SksurvAdapter. Previously, the resulting Empirical distributions were improper (weights summed to less than 1.0) and temporally shifted.
Changes:
Testing & Verification:
Verified using the reproduction script in Issue 958.