Skip to content

[ENH]: defaults tests:vm to not be excluded#1005

Open
joshdunnlime wants to merge 4 commits intosktime:mainfrom
joshdunnlime:ignore-local-vm
Open

[ENH]: defaults tests:vm to not be excluded#1005
joshdunnlime wants to merge 4 commits intosktime:mainfrom
joshdunnlime:ignore-local-vm

Conversation

@joshdunnlime
Copy link
Copy Markdown
Contributor

vm tests are now include, but explicity excluded in standard cicd test suite. test-est still picks these vm tests up as before.

Reference Issues/PRs

Fixes #682

What does this implement/fix? Explain your changes.

Add an expilicity skip_vm parameter. vm tests are skipped in the standard CI test suit. Inverting this allows vm tests to run locally. In CICD, this is turn back on to skip vm tests in the standard suite. These vm tests should still be picked up in the test-est CICD tests.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Do this still preserve CICD behaviour? Does this allow you to run a tests:vm test locally, without a workaround?

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

vm tests are now include, but explicity excluded instandard cicd test suite. test-est still picks these vm tests up as before.
@fkiraly fkiraly added enhancement module:tests test framework functionality - only framework, excl specific tests labels Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement module:tests test framework functionality - only framework, excl specific tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Allow "tests:vm": True override in local pytests

2 participants