[ENH]: defaults tests:vm to not be excluded#1005
Open
joshdunnlime wants to merge 4 commits intosktime:mainfrom
Open
[ENH]: defaults tests:vm to not be excluded#1005joshdunnlime wants to merge 4 commits intosktime:mainfrom
joshdunnlime wants to merge 4 commits intosktime:mainfrom
Conversation
vm tests are now include, but explicity excluded instandard cicd test suite. test-est still picks these vm tests up as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vm tests are now include, but explicity excluded in standard cicd test suite. test-est still picks these vm tests up as before.
Reference Issues/PRs
Fixes #682
What does this implement/fix? Explain your changes.
Add an expilicity skip_vm parameter. vm tests are skipped in the standard CI test suit. Inverting this allows vm tests to run locally. In CICD, this is turn back on to skip vm tests in the standard suite. These vm tests should still be picked up in the test-est CICD tests.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Do this still preserve CICD behaviour? Does this allow you to run a
tests:vmtest locally, without a workaround?Did you add any tests for the change?
No
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.