fix all AA operations in wasm #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wasm, a struct that wraps a single value is treated differently than just that single value by itself in the calling convention. This was causing issues when functions such as
_aaLenwould be called with anImpl*value, which was then trying to be re-interpreted as anAA, meaning that the function would get garbage input.This PR removes the
struct AAdefinition, since it was just a wrapper around a single value, and thus fixes these issues.