Skip to content

Use ResourcesCompat.getFont() for backwards compatibility with API 24 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfabulich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ResourcesCompat.getFont() for backwards compatibility with API 24 #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/SkipUI/SkipUI/Text/Font.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#if !SKIP_BRIDGE
#if SKIP
import android.graphics.Typeface
import androidx.core.content.res.ResourcesCompat
import androidx.compose.material3.MaterialTheme
import androidx.compose.runtime.Composable
import androidx.compose.ui.platform.LocalContext
Expand Down Expand Up @@ -212,7 +213,7 @@ public struct Font : Hashable {
} else {
android.util.Log.w("SkipUI", "unable to find font named: \(fontName) (\(name))")
}
} else if let customTypeface = ctx.resources.getFont(fid) {
} else if let customTypeface = ResourcesCompat.getFont(ctx, fid) {
fontFamily = FontFamily(customTypeface)
} else {
android.util.Log.w("SkipUI", "unable to find font named: \(name)")
Expand Down
Loading