Skip to content

Fix infinite recomposition in Text.foregroundStyle(LinearGradient()) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcprux merged 1 commit into from
May 30, 2026
Merged

Fix infinite recomposition in Text.foregroundStyle(LinearGradient()) #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Sources/SkipUI/SkipUI/Graphics/Gradient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ public struct LinearGradient : ShapeStyle, Renderable {

@Composable override func asBrush(opacity: Double, animationContext: ComposeContext?) -> Brush? {
let stops = gradient.colorStops(opacity: opacity)
return LinearGradientShaderBrush(colorStops: stops, startPoint: startPoint, endPoint: endPoint)
return remember(gradient, startPoint, endPoint, opacity) {
Comment thread
dfabulich marked this conversation as resolved.
LinearGradientShaderBrush(colorStops: stops, startPoint: startPoint, endPoint: endPoint)
}
}

private struct LinearGradientShaderBrush: ShaderBrush {
Expand Down Expand Up @@ -207,7 +209,9 @@ public struct EllipticalGradient : ShapeStyle, Renderable {

@Composable override func asBrush(opacity: Double, animationContext: ComposeContext?) -> Brush? {
let stops = gradient.colorStops(opacity: opacity)
return RadialGradientShaderBrush(colorStops: stops, center: center, startFraction: startFraction, endFraction: endFraction)
return remember(gradient, center, startFraction, endFraction, opacity) {
RadialGradientShaderBrush(colorStops: stops, center: center, startFraction: startFraction, endFraction: endFraction)
}
}

private struct RadialGradientShaderBrush: ShaderBrush {
Expand Down Expand Up @@ -275,7 +279,9 @@ public struct RadialGradient : ShapeStyle, Renderable {
let start = with(density) { startRadius.dp.toPx() }
let end = with(density) { endRadius.dp.toPx() }
let stops = gradient.colorStops(opacity: opacity)
return RadialGradientShaderBrush(colorStops: stops, center: center, startRadius: start, endRadius: end)
return remember(gradient, center, start, end, opacity) {
RadialGradientShaderBrush(colorStops: stops, center: center, startRadius: start, endRadius: end)
}
}

private struct RadialGradientShaderBrush: ShaderBrush {
Expand Down