Fix infinite recomposition in flexible containers#390
Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Open
Fix infinite recomposition in flexible containers#390dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Conversation
Flexible fill could cause `contentFlexibleWidthMax`/`contentFlexibleHeightMax` to increase due to a side effect, causing a decrease in the next side effect, causing an increase in the next side effect, and so on. Now, we only allow monotonically increasing values. Fixes skiptools#389
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flexible fill could cause
contentFlexibleWidthMax/contentFlexibleHeightMaxto increase due to a side effect, causing a decrease in the next side effect, causing an increase in the next side effect, and so on.Now, we only allow monotonically increasing values.
Fixes #389
Skip Pull Request Checklist:
swift testNot needed
Cursor generated the merge function. (I'm not entirely sure what the right expansion rank ought to be; it doesn't match the ordering in
StackLayouts.kt.)I visually inspected the Stacks playground, verified that infinite recomposition halted in automated tests. skiptools/skipapp-showcase#83