use unique_lock instead of mutex and re-wrote IterateEvents#45
Open
CalebWhiting wants to merge 1 commit intoskillbert:masterfrom
Open
use unique_lock instead of mutex and re-wrote IterateEvents#45CalebWhiting wants to merge 1 commit intoskillbert:masterfrom
CalebWhiting wants to merge 1 commit intoskillbert:masterfrom
Conversation
…an error occurs. Rewrote IterateEvents to use futures, which somehow made it work on my system (previously crashed on condvar.wait)
|
Had the same issue and this fixed it for me aswell. |
|
Tested this on my machine, somehow this causes the alt1 window to reset OS initiated moves and resizes of the window and only honours these actions if they are done through the window's own means to move or resize. It does, however, fix sporadic crashes that I was getting. |
|
The issue here is that Potential fixes are:
Though it doesn't seem like the repo is maintained anymore, just left this here for the various forks. |
|
Just a heads up, I incorporated this PR into my fork: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed crash as seen on issue #44
To be completely honest, I'm not a C++ savant. I don't know the root-cause of the crash except that it was this line
alt1-electron/native/os_x11_linux.cc
Line 266 in ae28add
And re-writing the IterateEvents method to use futures fixed it for me.