Skip to content

commented ntsecdesc type conversion so ACEs return.#59

Closed
dwalters0 wants to merge 1 commit intoskelsec:mainfrom
dwalters0:main
Closed

commented ntsecdesc type conversion so ACEs return.#59
dwalters0 wants to merge 1 commit intoskelsec:mainfrom
dwalters0:main

Conversation

@dwalters0
Copy link
Copy Markdown

I stayed up all night playing a CTF and all I found was a hash.

@dwalters0
Copy link
Copy Markdown
Author

Hi skelsec, I made a pull request. Why did the enc dictionary of translations contain nTSecurityDescriptor and print out bad bytes? By commenting it out of there so the conversion fell through to the lookup table in the elif, the ACEs were loaded instead which is more useful information.

I like msldap because it works well which is what got me pulling on this thread.

@skelsec
Copy link
Copy Markdown
Owner

skelsec commented Feb 4, 2025

Hello, thank you for the PR!
May I ask what bad bytes are you referring to?
This PR will be rejected, because the nTSecurityDescriptor must be returning bytes or bytearray object, for two reasons:

  1. this would impact the API in a major way.
  2. Parsing nTSecurityDescriptor to an object takes a lof of resources, and some queroies could easily return hunderds of nTSecurityDescriptors which would slow down the app considerably

@dwalters0
Copy link
Copy Markdown
Author

dwalters0 commented Feb 5, 2025

No bad bytes. I misinterpreted them. I like the objects. I'll see if I can get my script to handle the bytes else use my fork which uses code you had already written but didn't appear to be using.

@skelsec skelsec closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants