Two small additions to flat_hash_map#53
Open
jinxidoru wants to merge 1 commit intoskarupke:masterfrom
Open
Conversation
- skip clear() when the value is trivially destructible - added contains()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently encountered a problem in using flat_hash_map with really large data. I was surprised that the destructor was taking almost half a second to run. I realized it's because we were iterating over the entire table to destruct the entries, even though the entries were trivially destructible. This change will skip that last clear() call in the event that the destructors need not be run.
Secondly I added the contains() method since it was added to std::unordered_map<> with C++20.