SPR1-660: Fix sources setting during delaycal observations#484
SPR1-660: Fix sources setting during delaycal observations#484
Conversation
In calibrate_delays.py there is a rare occurrence where the source that is above the horizon at the start of the Observation then sets during the observation causing a failed observation
|
@ludwigschwardt can check that I have done this correctly . That I have not messed up units etc. |
ludwigschwardt
left a comment
ludwigschwardt
left a comment
There was a problem hiding this comment.
Have you checked that the three calibs won't leave a gap somewhere with horizon = 25? My OPT doesn't want to work at the moment... (all proposals are greyed out so I can't quickly check an old one).
| raise ValueError('Not enough receptors to do calibration - you ' | ||
| 'need 4 and you have %d' % (len(session.ants),)) | ||
| sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon) | ||
| sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5) |
There was a problem hiding this comment.
I would add some documentation here, e.g.
| sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5) | |
| # Lift horizon to avoid source setting while waiting for gains or during verification | |
| sources_above_horizon = observation_sources.filter(el_limit_deg=opts.horizon+5) |
That 5º buys you 20 minutes or so extra.
| help='Maximum length of time to wait for delays (K-cross diode), ' | ||
| 'solutions to be computed by pipeline (default=%default)') | ||
| # Set default value for any option (both standard and experiment-specific options) | ||
| parser.set_defaults(observer='comm_test', nd_params='off', project_id='COMMTEST', |
There was a problem hiding this comment.
You could also implement it directly as a horizon override in set_defaults (e.g. horizon=25 instead of the usual 20).
|
Mmm, it looks like there will be a gap between LST 10:30 and 12:00... The problem of lifting the horizon is that it affects both rising and setting sources, and you really only want to fix setting sources. 
Maybe it's better to do an explicit You can stack those filters, e.g. sources_above_horizon_now = observation_sources.filter(el_limit_deg=opts.horizon)
sources_above_horizon = sources_above_horizon_now.filter(
el_limit_deg=opts.horizon, timestamp=katpoint.Timestamp() + total_duration,
) |
|
Another request: please start your commit messages and branch names with SPR1-660, which will link this to the relevant Jira ticket. And finally: we should repeat this fix for phaseup too. |
ludwigschwardt
changed the title
2 participants
In calibrate_delays.py there is a rare occurrence where the source that is above the horizon at the start of the Observation then sets during the observation causing a failed observation