Open
Conversation
Define final output (multiqc_report.html) files in rule all
for Fastqc add cluster input
test for Keimbahn project
Owner
|
please ping me when the tests are passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new rule
two issues have to solve
lines
spike/rules/fastqc/Snakefile
Line 17 in 7e939e2
spike/rules/fastqc/Snakefile
Line 40 in 7e939e2
Sample_Project must be variable for different project
after solve the point 1, for AG_remke the new rule will not work
the reason is
spike/scripts/parse_samplesheet.py
Line 559 in 7e939e2
in this function # "only consider samples that have some spike_entity_role defined" and this not the case for AG_remke
one solutions is
spike/scripts/parse_samplesheet.py
Line 571 in 9f7e583