read 2 additional columns from bamststs file#178
Open
LayalYasin wants to merge 2 commits intomasterfrom
Open
Conversation
we often need to know the number of uncovered basepairs in a gene, in addition to the percentage of the covered regions. so I extracted these two additional values from bamstats.
sjanssen2
requested changes
Jul 9, 2019
Owner
sjanssen2
left a comment
sjanssen2
left a comment
There was a problem hiding this comment.
have you tested the updated function?
I fear it will throw a python syntax error. should be sum() and you have to remove a )
Owner
|
also missing: where and how are you going to report those numbers? |
actually I havnt tested the code. I will test it when we finish the pending runs, I will keep the branch for now, until I do the actual testing. w.r.t. where to use the additional columns, it will be written by result.to_csv to the usual output file.
Owner
|
Please also double check that those additional two columns do not break parsing the output files in function |
Collaborator
Author
|
ok, I did things the opposit way, I should have tested the code before pulling this branch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we often need to know the number of uncovered basepairs in a gene, in addition to the percentage of the covered regions. so I extracted these two additional values from bamstats.