Skip to content

Improve system configuration organization#298

Open
apodacaduron wants to merge 13 commits intomainfrom
improve-system-configuration-organization
Open

Improve system configuration organization#298
apodacaduron wants to merge 13 commits intomainfrom
improve-system-configuration-organization

Conversation

@apodacaduron
Copy link
Copy Markdown
Contributor

@apodacaduron apodacaduron commented Mar 23, 2026

Description

Adds a global search box to System Administration to find settings faster.
Selecting a result switches to the correct tab, scrolls to the setting, and highlights it.
Also adds and improves setting grouping titles

How to Test

  1. Open Admin > System Administration.
  2. Use the top search box.
  3. Select a suggestion and verify it navigates to the right tab, scrolls to the setting, and highlights it.
  4. Toggle dark mode and confirm highlight is still visible.
  5. Confirm regular tab/settings behavior is unchanged.

Jira ID (if applicable)

BYNT-1552

@apodacaduron apodacaduron self-assigned this Mar 23, 2026
@apodacaduron apodacaduron requested a review from level09 as a code owner March 23, 2026 22:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e69632e8-d05d-4e9f-b931-23f037d4f9ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-system-configuration-organization

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Daniel, this is a really useful addition — the search + scroll + highlight flow is smooth and well implemented. The Arabic normalization is a great touch too.

A couple of small things before merge:

  1. Missing search entries for a few mail settings: MAIL_USE_SSL, MAIL_USE_TLS, MAIL_USERNAME, and MAIL_PASSWORD aren't in settingsSearchMap. Would be good to add them for completeness.

  2. Wrapper divs for IDs: In some places the id could go directly on the existing element (e.g., the v-switch or v-col) instead of adding a wrapping <div id="setting-xxx">. Not a big deal but keeps the DOM cleaner where possible.

Both are quick fixes. Overall this is solid and ready after those tweaks.

@apodacaduron
Copy link
Copy Markdown
Contributor Author

@level09 Updated, i added pretty much all the missing settings, also did an improvement to show a snack if theres a setting that hidden under another one, for example AWS Region needs that S3 Storage is enabled.

As for "Wrapper divs for ID" i tried but as you know vuetify has many nested divs, so id's would be set on deep elements that prevented the custom background to show consistently, i moved it only on the places that worked fine like v-btn-toggle, h4, v-col, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants