Improve system configuration organization#298
Conversation
…hlight selected setting after navigation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
level09
left a comment
There was a problem hiding this comment.
Nice work Daniel, this is a really useful addition — the search + scroll + highlight flow is smooth and well implemented. The Arabic normalization is a great touch too.
A couple of small things before merge:
-
Missing search entries for a few mail settings:
MAIL_USE_SSL,MAIL_USE_TLS,MAIL_USERNAME, andMAIL_PASSWORDaren't insettingsSearchMap. Would be good to add them for completeness. -
Wrapper divs for IDs: In some places the
idcould go directly on the existing element (e.g., thev-switchorv-col) instead of adding a wrapping<div id="setting-xxx">. Not a big deal but keeps the DOM cleaner where possible.
Both are quick fixes. Overall this is solid and ready after those tweaks.
…ng is hidden behind a disabled parent feature
|
@level09 Updated, i added pretty much all the missing settings, also did an improvement to show a snack if theres a setting that hidden under another one, for example AWS Region needs that S3 Storage is enabled. As for "Wrapper divs for ID" i tried but as you know vuetify has many nested divs, so id's would be set on deep elements that prevented the custom background to show consistently, i moved it only on the places that worked fine like v-btn-toggle, h4, v-col, etc |
Description
Adds a global search box to System Administration to find settings faster.
Selecting a result switches to the correct tab, scrolls to the setting, and highlights it.
Also adds and improves setting grouping titles
How to Test
Jira ID (if applicable)
BYNT-1552