Open
Conversation
rhendrickson-sc
added
low priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #152
Issue
A file had CR LF line endings instead of the expected LF line endings.
Solution
find -type f -exec grep -Iq . {} \; -and -exec grep -Il $'\r' {} +to discover which files were affected.dos2unix ./docs/authorization.mdto convert the line endings on the file.find -type f -exec grep -Iq . {} \; -and -exec grep -Il $'\r' {} +to verify line endings were fixed.Image showing the steps done:
Impact
Should have no impact other than stopping IDEs from warning people that they're committing a file with CR LF line endings.
Usage Changes
No usage changed.
Considerations
Could always set up a GitHub Action pipeline that runs test for linting, formatting, and/or line endings?
Testing
Hard to write a test for a line ending change, but I ran
lando unitandlando sniffregardless, nothing I did affected the outputs of these commands, as it was the same before and after: