Feature merge (Headers, Data Allocations and TURNS/STUNS)#1635
Merged
Conversation
sipsorcery
approved these changes
May 24, 2026
Member
sipsorcery
left a comment
sipsorcery
left a comment
There was a problem hiding this comment.
The idea is to get all the Turn logic into the TurnClient class. The RtpIceChannel class has started to snowball a bit. That's a big'ish refactor though and this PR is worth merging in the meantime to get stuns and turns support.
Draft
Comment on lines
+38
to
+48
| public override bool MatchesExtension(string uri) | ||
| { | ||
| switch (uri.ToLower()) | ||
| { | ||
| case RTP_HEADER_EXTENSION_URI: | ||
| case "urn:ietf:params:rtp-hdrext:transport-wide-cc": //official urn registered with IANA | ||
| case "http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02": | ||
| return true; | ||
| } | ||
| return false; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging in updates i made in previous sipsorcery to bring it inline with current version.
Added support for matching multiple URIs in header extensions (fixes issues with various browsers)
Added offset and count to senddata (no API surface change) - reduces allocations
Added TURNS and STUNS support (tested)
Also nasty bug fix with DNS resolution immediately timing out due to DateTime.Now and DateTime.UTCNow conflict.