Add dialog owner registry for RFC 3891 Replaces dispatch#1526
Open
CraziestPower wants to merge 2 commits intosipsorcery-org:masterfrom
Open
Add dialog owner registry for RFC 3891 Replaces dispatch#1526CraziestPower wants to merge 2 commits intosipsorcery-org:masterfrom
CraziestPower wants to merge 2 commits intosipsorcery-org:masterfrom
Conversation
sipsorcery-org#1459) When multiple SIPUserAgent instances share a SIPTransport, an attended transfer INVITE with a Replaces header was processed by ALL agents. Non-matching agents would call AcceptCall (sending 100/180) and then reject with 400, racing against the correct agent's acceptance. Move the Replaces Call-ID check before AcceptCall so non-matching agents silently ignore the request instead of creating a UAS transaction. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…aces handling Adds a Call-ID keyed dialog owner registry to SIPTransport so that Replaces INVITEs are dispatched directly to the owning agent, with proper 481 responses when no matching dialog exists (RFC 3891 §3). - New ISIPDialogOwner interface for dialog-based dispatch - ConcurrentDictionary registry with Register/Unregister lifecycle - Dispatch intercept: Replaces→owner or 481, in-dialog→owner, else broadcast - Multiple Replaces headers → 400 Bad Request per RFC 3891 - SIPUserAgent and SIPNotifierClient implement ISIPDialogOwner - Supersedes the silent-ignore workaround from PR sipsorcery-org#1520 Fixes sipsorcery-org#1525 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Thanks for the PR. A code restructure has taken place and the source files for this PR are now in src/SIPSorcery. Can this PR be rebased? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISIPDialogOwnerinterface and Call-ID keyed registry toSIPTransportfor direct dialog-based request dispatchSIPUserAgentandSIPNotifierClientimplementISIPDialogOwnerwith full lifecycle management (register on dialog establishment, unregister on teardown)SIPTransportRequestReceivedFixes #1525
Related: #1459, #1520
Test plan
dotnet build— all targets compile (0 warnings, 0 errors)DialogRegistrycategory) — all passDialogDispatchcategory) — all pass🤖 Generated with Claude Code