Skip to content

fix: Makefile handle space in go1.25.10 X:nodwarf5#2976

Open
opsec-ai wants to merge 1 commit into
sipeed:mainfrom
opsec-ai:makefile_pr
Open

fix: Makefile handle space in go1.25.10 X:nodwarf5#2976
opsec-ai wants to merge 1 commit into
sipeed:mainfrom
opsec-ai:makefile_pr

Conversation

@opsec-ai
Copy link
Copy Markdown

@opsec-ai opsec-ai commented May 30, 2026

📝 Description

Well, it wouldn't compile. So I fiddled around with the "Makefoible" and discovered that it checks for go env GOVERSION and the build bails out with an error because of spaces in the return string.

github.com/sipeed/picoclaw/cmd/picoclaw/internal/gateway
github.com/sipeed/picoclaw/cmd/picoclaw
# github.com/sipeed/picoclaw/cmd/picoclaw
usage: link [options] main.o
  -B note
        set ELF NT_GNU_BUILD_ID note or Mach-O UUID; use "gobuildid" to generate it from the Go build ID; "none" to disable
        [snip]
  -v    print link trace
  -w    disable DWARF generation
make: *** [Makefile:207: build] Error 1

My go version:

$ go env GOVERSION
go1.25.10 X:nodwarf5

The fix was pretty simple. Use Makefile convention to split on first word.

🗣️ Type of Change

  • [☑️] 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • [☑️] ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

📚 Technical Context (Skip for Docs)

  • Reference URL:
  • Reasoning:

🧪 Test Environment

  • Hardware: Linux laptop
  • OS: Fedora 43
  • Model/Provider: Bonsai-4B-Q1_0.gguf
  • Channels:

📸 Evidence (Optional)

Click to view Logs/Screenshots

☑️ Checklist

  • My code/docs follow the style of this project.
  • [☑️] I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


themanyone seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants