fix(feishu): skip empty random_reaction_emoji entries#2131
Merged
yinwm merged 1 commit intosipeed:mainfrom Mar 30, 2026
Merged
Conversation
Feishu returns 231001 when emoji_type is empty. Config slices like ["", "Pin"] could randomly select an empty string; filter and trim entries and fall back to Pin when none remain. Made-with: Cursor
sipeed-bot
bot
added
type: bug
yinwm
approved these changes
Mar 30, 2026
Collaborator
yinwm
left a comment
yinwm
left a comment
There was a problem hiding this comment.
LGTM — clean defensive fix for the empty emoji edge case. The TrimSpace + fallback pattern is solid and backward-compatible. One non-blocking suggestion: consider adding a unit test for the emoji selection logic covering empty/all-whitespace/mixed configs to prevent regression.
|
@imalasong 飞书这个 emoji_type 为空时返回 231001 的边缘情况确实坑，加上 trim + fallback 处理之后逻辑清晰多了，感谢修复！ 我们正在组建 PicoClaw Dev Group Discord 群，方便大家交流协作。感兴趣的话发邮件到 |
ra1phdd
pushed a commit
to ra1phdd/picoclaw-pkg
that referenced
this pull request
Apr 12, 2026
fix(feishu): skip empty random_reaction_emoji entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Feishu returns 231001 when emoji_type is empty. Config slices like ["", "Pin"] could randomly select an empty string; filter and trim entries and fall back to Pin when none remain.
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
☑️ Checklist