Fix token (and other secret) loss when saving channel config by correctly including edited secret fields in save payload#2123
Closed
lbriers wants to merge 2 commits intosipeed:mainfrom
Closed
Fix token (and other secret) loss when saving channel config by correctly including edited secret fields in save payload#2123lbriers wants to merge 2 commits intosipeed:mainfrom
lbriers wants to merge 2 commits intosipeed:mainfrom
Conversation
Author
|
This caused issue: when inputting telegram channel token and pressing save, detected token field as being empty. |
Collaborator
|
Closing in favor of #2024 which includes the same frontend fix plus backend secret field mapping and regression tests. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
When editing channel secrets (e.g., token) the secret could be dropped from the saved JSON if the edited secret field (_token) was empty or the plain secret key was missing from editConfig. This ensures secret fields are preserved — preferring non-empty edited values (e.g., _token) and falling back to existing plain values (e.g., token) — and makes buildSavePayload robust.
🗣️ Type of Change
🤖 AI Code Generation
📚 Technical Context (Skip for Docs)
The previous implementation iterated editConfig and skipped underscore keys, then relied on encountering the plain secret key to copy or choose the edited secret. If the plain key was absent in editConfig, the secret could be omitted from payload, causing deletion on save. The new approach explicitly sets secret keys, avoiding accidental omission.
🧪 Test Environment
☑️ Checklist