improve cron deliver param description to clarify agent processing vs direct send#2121
Closed
champly wants to merge 2 commits intosipeed:mainfrom
Closed
improve cron deliver param description to clarify agent processing vs direct send#2121champly wants to merge 2 commits intosipeed:mainfrom
champly wants to merge 2 commits intosipeed:mainfrom
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies the deliver parameter semantics for the cron tool so tool callers (especially agents/LLMs) understand when a scheduled message is sent verbatim vs. processed through the agent before sending.
Changes:
- Expanded
deliverparameter description to explicitly distinguish “direct send as-is” vs. “agent processes then sends”. - Added stronger guidance to avoid using
deliver: truefor tasks that require computation/data fetching/content generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@Zepan PTAL |
sipeed-bot
bot
added
type: documentation
Contributor
Author
|
@yinwm PTAL |
alexhoshina
approved these changes
Mar 28, 2026
Collaborator
|
@champly pls fix lint and tests 🙏 |
Contributor
Author
this only modified the description here, it shouldn't affect the ut. |
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the
deliverparameter description in the cron tool to make the intended behavior more explicit:deliver: true: sends the message text directly to the channel as-is (only for fixed static text, no processing)deliver: false(default, strongly recommended): the agent processes the task and sends the resultThis helps prevent misuse where agents set
deliver: trueeven for tasks that require fetching data, calling APIs, searching news, or generating content.