Merged
Conversation
JulStraus
approved these changes
Nov 6, 2025
Collaborator
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Generally looking good, but I would have preferred British English :) Good to find all our typos and issues in the labels.
hellemo
approved these changes
Nov 6, 2025
Member
hellemo
left a comment
hellemo
left a comment
There was a problem hiding this comment.
Looks good to me, I added a comment where I'm not sure the suggested change is correct, or we should probably clarify/add a bit more explanation/detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just got access to Claude 4.5 so I took it for a test ride on the documentation of TimeStruct. Most of the suggested changes look good and there were some proper fixes a well. Some of the changes are to align with standard American English, and here I do not have a strong preference.