Skip to content

URL Updates and Google Warning #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cksammons7 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

URL Updates and Google Warning #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb9733
added meta and updated js and css to get html file to work
cksammons7 Apr 20, 2020
52a0ba5
updated divid to match cesiumjs tutorial
cksammons7 Apr 20, 2020
0ffa750
Updated geocoder to one that does not require a Key API
cksammons7 Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cesiumpy/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,11 @@ def __init__(self, divid=None, width='100%', height='100%',

@property
def _load_scripts(self):
js = """<script src="https://cesiumjs.org/Cesium/Build/Cesium/Cesium.js"></script>"""
css = """<link rel="stylesheet" href="https://cesiumjs.org/Cesium/Build/Cesium/Widgets/widgets.css" type="text/css">"""
meta = """<meta charset="utf-8">"""
js = """<script src="https://cesium.com/downloads/cesiumjs/releases/1.68/Build/Cesium/Cesium.js"></script>"""
css = """<link href="https://cesium.com/downloads/cesiumjs/releases/1.68/Build/Cesium/Widgets/widgets.css" rel="stylesheet">"""

return [js, css]
return [meta, js, css]

@property
def container(self):
Expand Down
2 changes: 1 addition & 1 deletion cesiumpy/extension/geocode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import cesiumpy.util.common as com

# ToDo: want different geocoders?
_GEOCODER = GoogleV3()
_GEOCODER = GeocodeFarm()
Copy link
Copy Markdown

@opt12 opt12 Jul 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me a

NameError: name 'GeocodeFarm' is not defined

Add the import to the beginning (line 7)



def _maybe_geocode(x, height=None):
Expand Down
2 changes: 1 addition & 1 deletion cesiumpy/util/trait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class _DIV(_HTMLObject):
def __init__(self, divid=None, width='100%', height='100%'):

if divid is None:
divid = 'container-{0}'.format(id(self))
divid = 'cesiumContainer'
self.divid = divid

self.width = width
Expand Down