feat: support customProps.cssUrls#19
Open
TatsuyaYamamoto wants to merge 5 commits intosingle-spa:mainfrom
Open
feat: support customProps.cssUrls#19TatsuyaYamamoto wants to merge 5 commits intosingle-spa:mainfrom
customProps.cssUrls#19TatsuyaYamamoto wants to merge 5 commits intosingle-spa:mainfrom
Conversation
|
Is this not already supported through the |
Author
|
My understanding is that In my case, I want to build single-spa application with Vite, so maybe I should create PR to provide vite-plugin. However, I think it would be better to support as a feature that is not dependent on a specific build tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for creating PR without asking in issues.
Motivation
I want my single-spa application be able to load css provided from root-config.
An application’s bundled css filename sometimes includes hash (
index.abcdef.css). Hash text is detemined in build-time, so bundled js file cannot know hashed css file url. In case single-spa(-css), css urls received in opts.cssUrls cannot has build-time hash.Example