DEVEXP-912: snippets migration #28
Conversation
… with the Sinch Java SDK'
…using the Java SDK'
…number using Java'
…r's to have to configure it
getting-started/conversation/send-text-message/client/src/main/resources/config.properties
Outdated
Show resolved
Hide resolved
getting-started/numbers/rent-and-configure/client/src/main/java/numbers/Snippet.java
Outdated
Show resolved
Hide resolved
getting-started/numbers/rent-and-configure/client/src/main/java/numbers/Snippet.java
Outdated
Show resolved
Hide resolved
| .setType(numberType) | ||
| .setRegionCode(regionCode) | ||
| .setSmsConfiguration( | ||
| SmsConfiguration.builder().setServicePlanId(servicePlanId).build()) |
There was a problem hiding this comment.
Although the other getting started insists and the fact the number will be rented and configured, in this one, the outcome will be the same, but we don't explain the SMS configuration part.
There was a problem hiding this comment.
Right (this is coming from current snippet implementation https://developers.sinch.com/docs/numbers/getting-started/java-sdk/rentany/#rent-the-first-available-number-using-the-java-sdk)
@alex-sberna Regarding this getting started title and content should highlight
What is your opinion ?
- remove the configuration part ?
- improve the comment to highlight the configuration ?
- ?
There was a problem hiding this comment.
For the rent any, I think it is important to highlight that you are renting and configuring the number in the same call, so improving the comment would be good.
getting-started/sms/send-sms-message/client/src/main/java/sms/Snippet.java
Outdated
Show resolved
Hide resolved
getting-started/sms/respond-to-incoming-message/server/src/main/resources/application.yaml
Show resolved
Hide resolved
asein-sinch
left a comment
asein-sinch
left a comment
There was a problem hiding this comment.
Approved, waiting for Alex's feedback
getting-started/conversation/send-text-message/client/src/main/java/SinchClientHelper.java
Outdated
Show resolved
Hide resolved
|
Successfully sent SMS using SMS API and Conversation API. However, I needed to manually Haven't tested/can't receive SMS because of ngrok restriction. |
|
I just tested handling an incoming message with SMS, which I now realize already existed and isn't part of this PR, but one thing I ran into was the validation/authorization of the callback URL, with the web secret. I think for a getting started/quickstart that that should be commented out by default, rather than having a user needing to comment it out. If someone is just starting and testing things out, they very likely won't bother contacting their account manager to get a secret added in order for it to work. |
…lates (support Conversation region configuration)
Done |
Done. |
No description provided.