improvement(grain): make trigger names in line with API since resource type not known#3598
improvement(grain): make trigger names in line with API since resource type not known#3598icecrasher321 merged 2 commits intostagingfrom
Conversation
PR SummaryMedium Risk Overview Legacy Grain trigger types are kept for compatibility but hidden in the UI. Webhook subscription creation is extended for the new triggers. Grain provider subscription logic maps Written by Cursor Bugbot for commit f39a305. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR improves the Grain trigger UX by introducing two new API-aligned trigger types — Key changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User selects Grain Trigger] --> B{selectedTriggerId}
B --> C[grain_item_added\nnew]
B --> D[grain_item_updated\nnew]
B --> E[grain_webhook\nAll Events]
B --> F[grain_recording_created\nhidden - legacy]
B --> G[grain_recording_updated\nhidden - legacy]
B --> H[grain_highlight_created\nhidden - legacy]
B --> I[grain_highlight_updated\nhidden - legacy]
B --> J[grain_story_created\nhidden - legacy]
C --> K[actionMap: added\neventTypeMap: empty]
D --> L[actionMap: updated\neventTypeMap: empty]
E --> M[actionMap: none\neventTypeMap: empty]
F --> N[actionMap: added\neventTypeMap: recording_added]
G --> O[actionMap: updated\neventTypeMap: recording_updated]
K --> P[POST /hooks\nversion:2, view_id, actions:added]
L --> Q[POST /hooks\nversion:2, view_id, actions:updated]
M --> R[POST /hooks\nversion:2, view_id\nno actions filter]
N --> P2[POST /hooks\nversion:2, view_id, actions:added]
style C fill:#22c55e,color:#fff
style D fill:#22c55e,color:#fff
style F fill:#94a3b8,color:#fff
style G fill:#94a3b8,color:#fff
style H fill:#94a3b8,color:#fff
style I fill:#94a3b8,color:#fff
style J fill:#94a3b8,color:#fff
Last reviewed commit: 33cf0de |
...Id]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx
Outdated
Show resolved
Hide resolved
|
bugbot run |
Summary
Grain view id decides resource type -- which makes current dropdown functionality quite confusing. This new version maintains alignment with actual API. No backwards compat broken.
Type of Change
Testing
tested manually
Checklist