fix(ashby): add secretToken to webhook creation and fix trigger UX#3580
fix(ashby): add secretToken to webhook creation and fix trigger UX#3580waleedlatif1 merged 5 commits intostagingfrom
Conversation
PR SummaryHigh Risk Overview Refactors the UI notification system by removing the workspace-level Written by Cursor Bugbot for commit 373481a. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR fixes the Ashby webhook integration by wiring up the required Key changes:
Issue found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as Trigger UI
participant PS as provider-subscriptions.ts
participant Ashby as Ashby API
participant PV as pending-verification.ts
participant WH as Webhook Endpoint
participant Proc as processor.ts
UI->>PS: Save Ashby trigger (apiKey, triggerId)
PS->>PS: Generate secretToken (UUID)
PS->>Ashby: POST webhook.create with requestUrl + secretToken
Ashby-->>PS: webhook id
PS->>PS: Store externalId and secretToken in providerConfig
PS->>PV: Register ashby in pending verification
Ashby->>WH: POST ping event (action=ping)
WH->>PV: ashby probeMatcher checks method and action
PV-->>WH: match (return 200)
WH-->>Ashby: 200 OK
Note over Ashby,Proc: Real webhook event arrives later
Ashby->>WH: POST event with Ashby-Signature header
WH->>Proc: verifyProviderAuth(request, rawBody)
Proc->>Proc: Read secretToken from providerConfig
Proc->>Proc: validateAshbySignature(secretToken, header, rawBody)
alt valid signature
Proc-->>WH: nil, proceed
else missing or invalid
Proc-->>WH: 401 Unauthorized
end
Last reviewed commit: 373481a |
|
@greptile |
|
@cursor review |
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/notifications/notifications.tsx
Show resolved
Hide resolved
…synthetic timer keys
|
@cursor review |
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/notifications/notifications.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Summary
secretTokenfield to Ashbywebhook.createAPI call (fixes "secretToken: Invalid input" error)Ashby-SignatureheaderType of Change
Testing
Tested manually
Checklist