Skip to content

fix(webhooks): return empty 200 for Slack to close modals cleanly #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Mar 9, 2026
Merged

fix(webhooks): return empty 200 for Slack to close modals cleanly #3492

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07822d1
fix(webhooks): return empty 200 for Slack to close modals cleanly
waleedlatif1 Mar 9, 2026
a9e7f36
fix(webhooks): add clarifying comment on Slack error path trade-off
waleedlatif1 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/sim/lib/webhooks/processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,6 +1166,12 @@ export async function queueWebhookExecution(
})
}

// Slack requires an empty 200 for interactive payloads (view_submission, block_actions, etc.)
// A JSON body like {"message":"..."} is not a recognized response format and causes modal errors
if (foundWebhook.provider === 'slack') {
return new NextResponse(null, { status: 200 })
}

// Twilio Voice requires TwiML XML response
if (foundWebhook.provider === 'twilio_voice') {
const providerConfig = (foundWebhook.providerConfig as Record<string, any>) || {}
Expand Down Expand Up @@ -1211,6 +1217,10 @@ export async function queueWebhookExecution(
)
}

if (foundWebhook.provider === 'slack') {
return new NextResponse(null, { status: 200 })
}
Comment thread
waleedlatif1 marked this conversation as resolved.

if (foundWebhook.provider === 'twilio_voice') {
const errorTwiml = `<?xml version="1.0" encoding="UTF-8"?>
<Response>
Expand Down