Skip to content

improvement(selectors): make selectorKeys declarative #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 5 commits into from
Feb 27, 2026
Merged

improvement(selectors): make selectorKeys declarative #3374

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
451ebc5
fix(webflow): resolution for selectors
icecrasher321 Feb 27, 2026
d118f3e
remove unecessary fallback'
icecrasher321 Feb 27, 2026
77633a7
fix teams selector resolution
icecrasher321 Feb 27, 2026
7164580
make selector keys declarative
icecrasher321 Feb 27, 2026
7c29341
selectors fixes
icecrasher321 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/sim/hooks/selectors/resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,16 @@ function resolveFileSelector(
}
case 'sharepoint':
return { key: 'sharepoint.sites', context, allowSearch: true }
case 'webflow':
if (subBlock.id === 'collectionId') {
case 'webflow': {
const paramId = subBlock.canonicalParamId ?? subBlock.id
if (paramId === 'collectionId') {
return { key: 'webflow.collections', context, allowSearch: false }
}
if (subBlock.id === 'itemId') {
if (paramId === 'itemId') {
return { key: 'webflow.items', context, allowSearch: true }
}
return { key: null, context, allowSearch: true }
}
default:
return { key: null, context, allowSearch: true }
}
Expand Down
Loading