fix(fathom): address second round PR review feedback

- Remove redundant 204 status check in deleteFathomWebhook (204 is ok)
- Use consistent undefined-guard pattern for all include flags
- Add .catch() fallback on webhook creation JSON parse
- Change recording_id default from 0 to null to avoid misleading sentinel

Author: waleedlatif1

apps/sim/lib/webhooks/provider-subscriptions.ts

@@ -835,7 +835,7 @@ export async function deleteFathomWebhook(webhook: any, requestId: string): Prom
       },
     })
 
-    if (!fathomResponse.ok && fathomResponse.status !== 404 && fathomResponse.status !== 204) {
+    if (!fathomResponse.ok && fathomResponse.status !== 404) {
       fathomLogger.warn(
         `[${requestId}] Failed to delete Fathom webhook (non-fatal): ${fathomResponse.status}`
       )
@@ -1403,9 +1403,9 @@ export async function createFathomWebhookSubscription(
       destination_url: notificationUrl,
       triggered_for: [triggeredForValue],
       include_summary: includeSummary !== undefined ? Boolean(includeSummary) : true,
-      include_transcript: Boolean(includeTranscript),
-      include_action_items: Boolean(includeActionItems),
-      include_crm_matches: Boolean(includeCrmMatches),
+      include_transcript: includeTranscript !== undefined ? Boolean(includeTranscript) : false,
+      include_action_items: includeActionItems !== undefined ? Boolean(includeActionItems) : false,
+      include_crm_matches: includeCrmMatches !== undefined ? Boolean(includeCrmMatches) : false,
     }
 
     fathomLogger.info(`[${requestId}] Creating Fathom webhook`, {
@@ -1423,10 +1423,13 @@ export async function createFathomWebhookSubscription(
       body: JSON.stringify(requestBody),
     })
 
-    const responseBody = await fathomResponse.json()
+    const responseBody = await fathomResponse.json().catch(() => ({}))
 
     if (!fathomResponse.ok) {
-      const errorMessage = responseBody.message || responseBody.error || 'Unknown Fathom API error'
+      const errorMessage =
+        (responseBody as Record<string, string>).message ||
+        (responseBody as Record<string, string>).error ||
+        'Unknown Fathom API error'
       fathomLogger.error(
         `[${requestId}] Failed to create webhook in Fathom for webhook ${webhookData.id}. Status: ${fathomResponse.status}`,
         { message: errorMessage, response: responseBody }

apps/sim/tools/fathom/list_meetings.ts

@@ -114,7 +114,7 @@ export const listMeetingsTool: ToolConfig<FathomListMeetingsParams, FathomListMe
       (meeting: Record<string, unknown> & { recorded_by?: Record<string, unknown> }) => ({
         title: meeting.title ?? '',
         meeting_title: meeting.meeting_title ?? null,
-        recording_id: meeting.recording_id ?? 0,
+        recording_id: meeting.recording_id ?? null,
         url: meeting.url ?? '',
         share_url: meeting.share_url ?? '',
         created_at: meeting.created_at ?? '',

apps/sim/tools/fathom/types.ts

@@ -21,7 +21,7 @@ export interface FathomListMeetingsResponse extends ToolResponse {
     meetings: Array<{
       title: string
       meeting_title: string | null
-      recording_id: number
+      recording_id: number | null
       url: string
       share_url: string
       created_at: string