fix(fathom): address PR review feedback

- Add response.ok checks to all 5 tool transformResponse functions
- Fix include_summary default to respect explicit false (check undefined)
- Add externalId validation before URL interpolation in webhook deletion

Author: waleedlatif1

apps/sim/lib/webhooks/provider-subscriptions.ts

@@ -817,6 +817,14 @@ export async function deleteFathomWebhook(webhook: any, requestId: string): Prom
       return
     }
 
+    const idValidation = validateAlphanumericId(externalId, 'Fathom webhook ID', 100)
+    if (!idValidation.isValid) {
+      fathomLogger.warn(
+        `[${requestId}] Invalid externalId format for Fathom webhook deletion ${webhook.id}, skipping cleanup`
+      )
+      return
+    }
+
     const fathomApiUrl = `https://api.fathom.ai/external/v1/webhooks/${externalId}`
 
     const fathomResponse = await fetch(fathomApiUrl, {
@@ -1391,12 +1399,10 @@ export async function createFathomWebhookSubscription(
 
     const triggeredForValue = triggeredFor || 'my_recordings'
 
-    const hasInclude =
-      includeSummary || includeTranscript || includeActionItems || includeCrmMatches
     const requestBody: Record<string, any> = {
       destination_url: notificationUrl,
       triggered_for: [triggeredForValue],
-      include_summary: hasInclude ? Boolean(includeSummary) : true,
+      include_summary: includeSummary !== undefined ? Boolean(includeSummary) : true,
       include_transcript: Boolean(includeTranscript),
       include_action_items: Boolean(includeActionItems),
       include_crm_matches: Boolean(includeCrmMatches),

apps/sim/tools/fathom/get_summary.ts

@@ -33,6 +33,20 @@ export const getSummaryTool: ToolConfig<FathomGetSummaryParams, FathomGetSummary
   },
 
   transformResponse: async (response: Response) => {
+    if (!response.ok) {
+      const errorData = await response.json().catch(() => ({}))
+      return {
+        success: false,
+        error:
+          (errorData as Record<string, string>).message ||
+          `Fathom API error: ${response.status} ${response.statusText}`,
+        output: {
+          template_name: null,
+          markdown_formatted: null,
+        },
+      }
+    }
+
     const data = await response.json()
     const summary = data.summary ?? data
 

apps/sim/tools/fathom/get_transcript.ts

@@ -34,6 +34,19 @@ export const getTranscriptTool: ToolConfig<FathomGetTranscriptParams, FathomGetT
     },
 
     transformResponse: async (response: Response) => {
+      if (!response.ok) {
+        const errorData = await response.json().catch(() => ({}))
+        return {
+          success: false,
+          error:
+            (errorData as Record<string, string>).message ||
+            `Fathom API error: ${response.status} ${response.statusText}`,
+          output: {
+            transcript: [],
+          },
+        }
+      }
+
       const data = await response.json()
       const transcript = (data.transcript ?? []).map(
         (entry: { speaker?: Record<string, unknown>; text?: string; timestamp?: string }) => ({

apps/sim/tools/fathom/list_meetings.ts

@@ -94,6 +94,20 @@ export const listMeetingsTool: ToolConfig<FathomListMeetingsParams, FathomListMe
   },
 
   transformResponse: async (response: Response) => {
+    if (!response.ok) {
+      const errorData = await response.json().catch(() => ({}))
+      return {
+        success: false,
+        error:
+          (errorData as Record<string, string>).message ||
+          `Fathom API error: ${response.status} ${response.statusText}`,
+        output: {
+          meetings: [],
+          next_cursor: null,
+        },
+      }
+    }
+
     const data = await response.json()
 
     const meetings = (data.items ?? []).map(

apps/sim/tools/fathom/list_team_members.ts

@@ -49,6 +49,20 @@ export const listTeamMembersTool: ToolConfig<
   },
 
   transformResponse: async (response: Response) => {
+    if (!response.ok) {
+      const errorData = await response.json().catch(() => ({}))
+      return {
+        success: false,
+        error:
+          (errorData as Record<string, string>).message ||
+          `Fathom API error: ${response.status} ${response.statusText}`,
+        output: {
+          members: [],
+          next_cursor: null,
+        },
+      }
+    }
+
     const data = await response.json()
     const members = (data.items ?? []).map(
       (member: { name?: string; email?: string; created_at?: string }) => ({

apps/sim/tools/fathom/list_teams.ts

@@ -36,6 +36,20 @@ export const listTeamsTool: ToolConfig<FathomListTeamsParams, FathomListTeamsRes
   },
 
   transformResponse: async (response: Response) => {
+    if (!response.ok) {
+      const errorData = await response.json().catch(() => ({}))
+      return {
+        success: false,
+        error:
+          (errorData as Record<string, string>).message ||
+          `Fathom API error: ${response.status} ${response.statusText}`,
+        output: {
+          teams: [],
+          next_cursor: null,
+        },
+      }
+    }
+
     const data = await response.json()
     const teams = (data.items ?? []).map((team: { name?: string; created_at?: string }) => ({
       name: team.name ?? '',