Implement absences

[netlob]

tested and fully function (as expected ;))

test:
activity ✓ should fetch activities and parts (335ms)

[lieuwex]

So I totally forgot this, but we already had absences in the appointments function. I don't really know the reason anymore but it basically was made so that you can only fetch absences when fetching appointments. This was the same in v1.

So the question: is it useful to fetch absences without having the appointment?
If that's the case this function would be useful, but in that case you can change the absence fetch code in appointments to utilize your new function, or remove the feature of appointments entirely.

[netlob]

The absence function in appointments is only for that one appointment right? This gives a full array of your absences and as far as I know the absence thingy in appointments is only for the specific appointment🤔

I'll check on this later. Atleast for my use, I would like to retrieve the absences apart from the appointments, but I don't know how other users are using that function right now... Maybe double absences function😝

[jvdoorn]

MagisterJS/src/magister.js

Lines 145 to 166 in 545b633

	let absencesPromise = Promise.resolve([])
	if (fetchAbsences) {
	const absencesUrl = `${this._personUrl}/absenties?van=${fromUrl}&tot=${toUrl}`
	absencesPromise = this._privileges.needs('Absenties', 'read')
	.then(() => this.http.get(absencesUrl))
	.then(res => res.json())
	.then(res => res.Items.map(a => new AbsenceInfo(this, a)))
	if (ignoreAbsenceErrors) {
	absencesPromise = absencesPromise.catch(() => [])
	}
	}
	return Promise.all([ appointmentsPromise, absencesPromise ])
	.then(([ appointments, absences ]) => {
	for (const a of appointments) {
	a.absenceInfo = absences.find(i => i.appointment.id === a.id)
	}
	return appointments
	})
	.then(appointments => _.sortBy(appointments, 'start'))

The method that is used right now to fetch absences is the same as your new method so as @lieuwex suggested I would indeed change the old method to use yours. Alternatively you could also opt to not fetch the absence info when fetching appointments and make a method for it in the appointment class. A pro of doing this is that you need less time to fetch appointments because I doubt absence info is used a lot. And if someone needs absence info they can call your method.

[gruijter]

Just FYI: I use absence info in my Homey app. But if I need to rewrite my app because of this change I'll do it :)